Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the build process to use a staging directory for
_maps._mapsdirectory tree to the staging directory.staging/_maps._mapsdirectory tree of everymodular_starflymodule to the staging directory.modular_starfly/starfly_ships/_mapsdirectory tree.The build process then checks to see if this staging directory exists, and uses it instead of
_maps.This should let us add/change/remove anything we want in a nice modular way.
One caveat; if you provide identical filenames in different modules, whichever one bash picks last will be the winner.
So try to avoid duplication between modules.